Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(waf): enable waf and add challenges #784

Merged
merged 2 commits into from Sep 28, 2023

Conversation

roleyfoley
Copy link
Contributor

Intent of Change

  • New feature (non-breaking change which adds functionality)

Description

  • Add userpool association for WAF
  • Add support for CAPTCHA and CHALLENGE WAF actions
  • Fixes some ARN lookups and output id saving for waf

Motivation and Context

AWS implementation of hamlet-io/engine#2122

How Has This Been Tested?

Tested locally and on native deployment

Related Changes

Prerequisite PRs:

  • None

Dependent PRs:

  • None

Consumer Actions:

  • None

- Add userpool association for WAF
- Add support for CAPTCHA and CHALLENGE WAF actions
- Fixes some ARN lookups and output id saving for waf
@roleyfoley roleyfoley requested a review from a team September 26, 2023 02:05
Copy link
Contributor

@RossMurr4y RossMurr4y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roleyfoley roleyfoley merged commit 66a0519 into hamlet-io:master Sep 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants