fix: remove use of getRegistryPrefix and EndPoint #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent of Change
Description
Replace/remove getRegistryPrefix and getRegistryEndPoint calls
It would be useful if someone that understands the motivation behind the change in location identification could check this is consistent with the reason for the removal of getRegistryPrefix and getRegistryEndPoint
Motivation and Context
Current failures in Azure plugin causes tram and train hamlet builds to fail
How Has This Been Tested?
Locally run test suite to ensure AWS tram and train can be built
Related Changes
Prerequisite PRs:
Dependent PRs:
Consumer Actions: