Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove gen contract from stack outputs #2089

Conversation

roleyfoley
Copy link
Contributor

Intent of Change

  • Bug fix (non-breaking change which fixes an issue)

Description

  • Don't include the generation contract for stack outputs to avoid git conflicts when two occurrences in a deployment unit update at the same time

Motivation and Context

When using a single deployment unit for all docker based registries if two pipelines update the image references at the same time conflicts are raised on the generation contract. We don't need to care about what was generated in a single file output so it can just be removed.

How Has This Been Tested?

Tested locally

Related Changes

Prerequisite PRs:

  • None

Dependent PRs:

  • None

Consumer Actions:

  • None

- Don't include the generation contract for stack outputs to avoid
git conflicts when two occurrences in a deployment unit update
at the same time
@roleyfoley roleyfoley requested a review from a team February 17, 2023 01:34
@roleyfoley roleyfoley merged commit d32681b into hamlet-io:master Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant