Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apigateway): private APIs #2115

Merged
merged 1 commit into from Jul 3, 2023

Conversation

ml019
Copy link
Contributor

@ml019 ml019 commented Jul 1, 2023

Intent of Change

  • New feature (non-breaking change which adds functionality)

Description

Add the option of private APIs. For these APIS, traffic filtering is done on the basis of VPC endpoints rather than IP addresses. The VPC endpoints are assumed to be configured via inbound links to external services, which should provide a VPC_ENDPOINTS attribute containing a command separated list of vpc endpoint names.

Adjust the available values for the authorisation model to support either IPs or VPC Endpoints.

Motivation and Context

  • support new AWS feature
  • support more security conscious deployment

How Has This Been Tested?

Local template generation

Related Changes

Prerequisite PRs:

  • None

Dependent PRs:

  • None

Consumer Actions:

  • None

@ml019 ml019 force-pushed the feat/api-gateway-private-api branch 3 times, most recently from d503c8a to c54bbca Compare July 3, 2023 11:11
Add the option of private APIs. For these APIS, traffic filtering is
done on the basis of VPC endpoints rather than IP addresses. The VPC
endpoints are assumed to be configured via inbound links to external
services, which should provide a VPC_ENDPOINTS attribute containing a
command separated list of vpc endpoint names.

Adjust the available values for the authorisation model to support
either IPs or VPC Endpoints.
@roleyfoley roleyfoley force-pushed the feat/api-gateway-private-api branch from c54bbca to 75dcdd1 Compare July 3, 2023 23:23
@roleyfoley roleyfoley enabled auto-merge (squash) July 3, 2023 23:23
@roleyfoley roleyfoley merged commit e24f3df into hamlet-io:master Jul 3, 2023
2 checks passed
@ml019 ml019 deleted the feat/api-gateway-private-api branch July 6, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants