Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0.8 - branches es2015 - pressRecognizer setTimeoutContext error #1129

Open
savethegreen7 opened this issue Aug 10, 2017 · 0 comments
Open

Comments

@savethegreen7
Copy link

savethegreen7 commented Aug 10, 2017

hello~*
When the time value is decreased (0 or 10ms), the up event occurs once more after mouse down-up.
It seems that PressRecognizer did not call clearTimeout (this._timer).

seems need to change this one ->

if (!validMovement || !validPointers || (input.eventType & (INPUT_END | INPUT_CANCEL) && !validTime)) {
this.reset();
} else if (input.eventType & INPUT_START) {
this.reset();
this._timer = setTimeoutContext(() => {
// Input.eventType is resolved to INPUT_END.
this.state = STATE_RECOGNIZED;
this.tryEmit();
}, options.time, this);
} else if (input.eventType & INPUT_END) {
this.reset(); // Where to fix
return STATE_RECOGNIZED;
}

https://hammerjs.slack.com/files/briller/F6B7DNM9P/-.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant