Optionally filter by number of mismatches after the variant #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iskandr
reviewed
Jan 17, 2017
| if len_diff > 0: | ||
| # if the reference is shorter than the read, the read runs into the intron - these count as | ||
| # mismatches. pad the reference suffix if necessary with underscores | ||
| reference_suffix += '_' * len_diff |
There was a problem hiding this comment.
Not a fan of modifying the cDNA sequence with extra characters. Why not just add max(0, len_diff) to the sum below?
There was a problem hiding this comment.
makes much more sense, done
iskandr
approved these changes
Jan 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
at least during matching sequence to reference context.
@iskandr am I missing any other points in isovar logic where I need to take the number of mismatches after the variant into account?
Fixes #73
This change is