Fix Ensembl release 83 #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rk with ensembl81
| ensembl83 = cached_release(83) | ||
| ensembl_grch38 = ensembl83 # most recent for GRCh38 | ||
|
|
||
| __all__ = [ |
There was a problem hiding this comment.
I don't know much about __all__ other than some brief Googling; any particular reason you decided to add this now?
There was a problem hiding this comment.
I thought it might be slightly better package etiquette to restrict which things get imported as '*'. I'm not totally sure if it's necessary though.
https://docs.python.org/2/tutorial/modules.html#importing-from-a-package
|
LGTM % minor questions |
iskandr
added a commit
that referenced
this pull request
Feb 22, 2016
…objects Fix Ensembl release 83
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ensembl77,ensembl83, &c since it seems like bad design to add another one of those for each Ensembl release