Transcript.coding_sequence didn't work for non-coding transcripts #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # .e.g. | ||
| # "ENST00000448914.1" instead of "ENST00000448914" | ||
| # So now we have to parse out the identifier | ||
| seq_id = seq_entry.metadata["id"].split(".")[0] |
There was a problem hiding this comment.
Can you add a test that would break if you didn't have this?
There was a problem hiding this comment.
I did, check out test_transcript_sequence_ensembl83
There was a problem hiding this comment.
Oops, somehow didn't think that would cover it, cool
|
LGTM |
iskandr
added a commit
that referenced
this pull request
Feb 23, 2016
Transcript.coding_sequence didn't work for non-coding transcripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transcript.sequence