-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added NCBIM37 to list of references for mouse #146
Conversation
reference_assemblies={ | ||
"GRCm38": (78, MAX_ENSEMBL_RELEASE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you walk me through the numbers, here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just flipped through different release directories on the Ensembl FTP
server until I found the change-point from NCBIM37 to GRCm38 (which
happened after Ensembl 67).
LGTM |
Watch out @tavinathanson, FASTA parser coming your way. (I'm sorry: to you, to the Hammerlab, to humanity at large) |
After in-person code review LGTM 👍 |
This change is