Added NCBIM37 to list of references for mouse #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| reference_assemblies={ | ||
| "GRCm38": (78, MAX_ENSEMBL_RELEASE) |
There was a problem hiding this comment.
Can you walk me through the numbers, here?
There was a problem hiding this comment.
I just flipped through different release directories on the Ensembl FTP
server until I found the change-point from NCBIM37 to GRCm38 (which
happened after Ensembl 67).
|
LGTM |
|
Watch out @tavinathanson, FASTA parser coming your way. (I'm sorry: to you, to the Hammerlab, to humanity at large) |
|
After in-person code review LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is