Deserialization should construct cached EnsemblRelease objects #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctor for deserialization, added test for uniqueness of instances
|
It would be nice to do something similar for the |
| the same EnsemblRelease object since each one will store a lot of cached | ||
| annotation data in-memory. | ||
| Keeping this function for backwards compatibility but this functionality | ||
| has been moving onto the EnsemblRelease object itself by overriding __new__. |
There was a problem hiding this comment.
Where are you overriding new?
There was a problem hiding this comment.
Sorry, that's left over from an old attempt (turned out too arcane).
| if init_args_tuple in cls._genome_cache: | ||
| genome = cls._genome_cache[init_args_tuple] | ||
| else: | ||
| genome = cls._genome_cache[init_args_tuple] = cls(*init_args_tuple) |
There was a problem hiding this comment.
Didn't even know this was valid syntax! It's right to left?
There was a problem hiding this comment.
Yep, right to left (like Arabic!). It's a generalization of a = b = None.
|
Agree that we need to generalize this, but good to have a solution for now! |
|
LGTM |
iskandr
deleted the
use-cached-ensembl-release-objects-after-pickling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cached_releaseonto the EnsemblRelease object (EnsemblRelease.cached)WeakValueDictionaryinstead of ordinary dict to avoid memory leakfrom_dictclass method to usecachedfor deserializationThis change is