Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namedtuples -> Objects #82

Merged
merged 3 commits into from Jan 12, 2018
Merged

Namedtuples -> Objects #82

merged 3 commits into from Jan 12, 2018

Conversation

iskandr
Copy link
Contributor

@iskandr iskandr commented Dec 20, 2017 •
edited by tavinathanson

Refactoring namedtuples with ad-hoc inheritance is pretty tricky, so before I add another kind of EpitopePrediction descendant for protein-level changes I'm first getting rid of namedtuples.

This change is Reviewable

@coveralls
Copy link

coveralls commented Dec 21, 2017 •
edited

Coverage Status

Coverage increased (+1.0%) to 88.235% when pulling 73ffd31 on get-rid-of-namedtuples into a90625c on master.

@coveralls
Copy link

coveralls commented Dec 21, 2017 •
edited

Coverage Status

Coverage increased (+0.05%) to 87.578% when pulling 8a6cc38 on get-rid-of-namedtuples into f00a582 on master.

@iskandr iskandr merged commit ccd6ef9 into master Jan 12, 2018
@iskandr iskandr deleted the get-rid-of-namedtuples branch February 8, 2018 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julia326 julia326 Awaiting requested review from julia326

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iskandr @coveralls