Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

One logger per module. #197

Merged
merged 3 commits into from
Oct 11, 2016
Merged

One logger per module. #197

merged 3 commits into from
Oct 11, 2016

Conversation

julia326
Copy link
Contributor

@julia326 julia326 commented Oct 5, 2016 •
edited by tavinathanson

Not setting up a logging config; assuming varcode is only used as a library.

Fixes #196

This change is Reviewable

@coveralls
Copy link

coveralls commented Oct 5, 2016 •
edited

Coverage Status

Coverage increased (+0.7%) to 88.756% when pulling 56edb53 on varcode-logger into d7383f9 on master.

@ihodes
Copy link

ihodes commented Oct 6, 2016

LGTM

@coveralls
Copy link

coveralls commented Oct 11, 2016 •
edited

Coverage Status

Coverage increased (+0.06%) to 88.979% when pulling a6e4f99 on varcode-logger into cdde051 on master.

@julia326 julia326 merged commit b6c4a21 into master Oct 11, 2016
@julia326 julia326 deleted the varcode-logger branch October 11, 2016 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@iskandr iskandr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@julia326 @coveralls @ihodes @iskandr