Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally allow duplicated mutations when using load_vcf or load_maf. Fixes #211 #212

Merged
merged 4 commits into from
Apr 11, 2017
Merged

Optionally allow duplicated mutations when using load_vcf or load_maf. Fixes #211 #212

merged 4 commits into from
Apr 11, 2017

Conversation

tuomastik
Copy link
Contributor

@tuomastik tuomastik commented Jan 20, 2017

This change is Reviewable

@coveralls
Copy link

coveralls commented Jan 20, 2017

Coverage Status

Coverage remained the same at 88.582% when pulling 46ed6b4 on tuomastik:allow_duplicated_mutations into c0fcf14 on hammerlab:master.

@iskandr
Copy link
Contributor

iskandr commented Mar 26, 2017

Looks like this failed on Travis because of unrelated (need to install Ensembl 87 on travis), I'll fix that shortly and re-run your tests.

@coveralls
Copy link

coveralls commented Mar 29, 2017

Coverage Status

Coverage remained the same at 88.218% when pulling 22dcb0f on tuomastik:allow_duplicated_mutations into 97c7a2b on hammerlab:master.

@iskandr
Copy link
Contributor

iskandr commented Apr 1, 2017

Hey @tuomastik I merged your other PR and I think that created merge conflicts with this one. I also moved the confusing sort order of VariantCollection to a separate issue. Thanks for these PRs! Sorry I've been slow in getting to them.

@tuomastik
Copy link
Contributor Author

Thanks @iskandr and no worries about the time taken! I just resolved the conflicts with the base branch.

@coveralls
Copy link

coveralls commented Apr 10, 2017

Coverage Status

Coverage remained the same at 88.218% when pulling 3322533 on tuomastik:allow_duplicated_mutations into 189ba0b on hammerlab:master.

@coveralls
Copy link

coveralls commented Apr 11, 2017

Coverage Status

Coverage remained the same at 87.294% when pulling a5a8d16 on tuomastik:allow_duplicated_mutations into 6a97720 on hammerlab:master.

@iskandr iskandr merged commit f70f3e3 into openvax:master Apr 11, 2017
@iskandr
Copy link
Contributor

iskandr commented Apr 11, 2017

Hey @tuomastik, I'll update the Varcode version on PyPI later today, thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants