Fixes to load_maf #223
Merged
Fixes to load_maf #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iskandr
approved these changes
Apr 28, 2017
|
@iskandr can you think of any reason I should have left |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
encodingthrough; I had some MAFs that neededencoding="latin1"when in Python 3, for example. Add a test to ensure that this does not break Python 2 (was seeingBio.Seqerrors if I did not convertrefandalttostrin Python 2).isnullrather thanisnan; the latter errors when chromosomes are strings vs. numerical (TypeError: ufunc 'isnan' not supported for the input types, and the inputs could not be safely coerced to any supported types according to the casting rule ''safe''). Added a test for this.Curious if I can handle any of the above more intelligently?
This change is