Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reintroduce ARC #10

Closed
Habbie opened this issue Oct 10, 2014 · 0 comments · Fixed by #30
Closed

Reintroduce ARC #10

Habbie opened this issue Oct 10, 2014 · 0 comments · Fixed by #30
Milestone
1.0

Comments

@Habbie
Copy link
Contributor

Habbie commented Oct 10, 2014

As far as i can see, the only reason ARC is not being used now is that the luarocks build scripts for osx use compiler flags (like supporting old OSX versions) that prevent it. This is not a good reason for not having ARC.

Diffing window.m between Hydra and Mjolnir mostly shows ARC removal, suggesting that in general the changes between ARC and non-ARC are minor.
@cmsj cmsj added this to the 1.0 milestone Oct 14, 2014
@cmsj cmsj mentioned this issue Oct 14, 2014
Merged
@cmsj cmsj closed this as completed in #30 Oct 15, 2014
latenitefilms referenced this issue in latenitefilms/hammerspoon Apr 8, 2017
@randomeizer
#10
94c1ae6 
* Updated version number to 1.0.0-beta.1
latenitefilms referenced this issue in latenitefilms/hammerspoon Apr 8, 2017
@latenitefilms
#10
2f66033 
- Updated appcast.xml for testing
- Added Sparkle Signing Scripts
asmagill pushed a commit that referenced this issue Sep 15, 2017
@latenitefilms
Merge pull request #10 from asmagill/lnf-applescriptWerrors
c4f804f 
AppleScript runstring can throw errors
@latenitefilms latenitefilms mentioned this issue Feb 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Bring ARC back for building extensions Hammerspoon/hammerspoon
2 participants
@cmsj @Habbie