Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop copying makefiles around in build_extensions.sh #34

Closed
cmsj opened this issue Oct 15, 2014 · 1 comment
Closed

Stop copying makefiles around in build_extensions.sh #34

cmsj opened this issue Oct 15, 2014 · 1 comment
Labels

Comments

@cmsj
Copy link
Member

cmsj commented Oct 15, 2014

There must be a way to use make -f with the generic Makefile, and still be able to infer the name of the module within the Makefile itself. Right now it doesn't work because of the first two lines of the generic Makefile.

@Habbie Habbie added the nit label Oct 18, 2014
@cmsj
Copy link
Member Author

cmsj commented Aug 5, 2015

I'm circling back to the extension stuff at the moment, mostly because I'm on an underpowered Mac for a few weeks, and building all of the extensions every time I build Hammerspoon, is driving me crazy.

So, I'm (for probably the 4th or 5th time) attacking the problem of how to get Xcode to build the extensions natively, instead of using scripts and Makefiles.

I think we need to make this change eventually, and I'm happy to do the work now, but it is going to need some changes in the structure of our app bundle. It doesn't have to mean any changes for third party modules though, so let's not get worried about that.

Given the current experiment I have going, I believe I can get the extensions to build as dylibs (really just a .so) and be copied into the app bundle, but I'm not sure I can easily preserve the structure of Resources/extensions/hs/

Right now it's looking like we'll continue to have Resources/extensions/hs/foo/init.lua, but then the C part will be Resources/extensions/hs/libfoo.dylib, which means the init.lua would need to have a different require() for its companion C library. This is a slightly wrinkle for anyone who's doing external builds of an extension we ship, but I'm not sure if anyone is actually doing that ( @asmagill ?)

I'll keep banging at it and see what I can come up with, but ultimately I think I would prefer to disturb the third party workflow, to get our build system under control.

@cmsj cmsj closed this as completed in #468 Aug 7, 2015
cmsj added a commit that referenced this issue Aug 7, 2015
Switch all extensions from using our scripted/hacky home grown build system, to being library targets in Hammerspoon.xcodeproj. Closes #34
latenitefilms added a commit to latenitefilms/hammerspoon that referenced this issue Dec 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants