Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows build-pngs never wires files to disk #65

Closed
JoueBien opened this issue Apr 16, 2020 · 2 comments
Closed

Windows build-pngs never wires files to disk #65

JoueBien opened this issue Apr 16, 2020 · 2 comments
Labels

Comments

@JoueBien
Copy link

The behaviour
using

npm run build-pngs -- :30

creates an empty folder with no images after converting SVG flags

The expected behaviour
folder is created and images are written to disk.

@wyattoday wyattoday added the bug label Jan 19, 2021
@pe2mbs
Copy link

pe2mbs commented Feb 12, 2021

Same on Linux Mint, after playing a-round i ended up with

   # for file in *.svg; do svgexport $file "`basename $file svg`png" pad 50: ; done

This gave the error:
(node:31183) UnhandledPromiseRejectionWarning: Error: Could not find browser revision 756035. Run "npm install" or "yarn install" to download a browser binary.
at ChromeLauncher.launch (/usr/local/lib/node_modules/svgexport/node_modules/puppeteer/lib/Launcher.js:59:23)
(node:31183) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:31183) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

This error is not seen when running the script:

   # node scripts/build-pngs.js 50:

It just runs all the flag files from svg/ without reporting any error, just an empty output folder.

@wyattoday
Copy link
Collaborator

I don't use that script, but it looks like the error is telling you exactly what is wrong and how to fix it. Similarly, using google will give you more detailed solutions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants