Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test fail #5

Closed
deogracia opened this issue Dec 8, 2016 · 4 comments
Closed

test fail #5

deogracia opened this issue Dec 8, 2016 · 4 comments

Comments

@deogracia
Copy link

deogracia commented Dec 8, 2016

Hi,

I clone this repo and I use commit #2f521d8c723e7dc5c38d1c76d5c739a54f8c21d3.

When I run python3 setup.py, I have these following FAIL

running build_ext
test_all (ukpostcodeparser.test.parser.TestParser) ... FAIL
test_all (ukpostcodeparser.test.parser.TestParser) ... FAIL

======================================================================
FAIL: test_all (ukpostcodeparser.test.parser.TestParser)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/lfelicite/Travail/projects/perso/chakra/chakraos-ccr-my-contrib/python3-ukpostcodeparser/src/ukpostcodeparser/ukpostcodeparser/test/parser.py", line 159, in test_all
    self.assertEqual(actual_result, required_result)
AssertionError: ('W1M', '4ZZ') != 'ValueError'

======================================================================
FAIL: test_all (ukpostcodeparser.test.parser.TestParser)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/lfelicite/Travail/projects/perso/chakra/chakraos-ccr-my-contrib/python3-ukpostcodeparser/src/ukpostcodeparser/ukpostcodeparser/test/parser.py", line 159, in test_all
    self.assertEqual(actual_result, required_result)
AssertionError: ('W1M', '4ZZ') != 'ValueError'

----------------------------------------------------------------------
Ran 2 tests in 0.011s

FAILED (failures=2)

I got the same error if I use the latest commit ( #4040f2cdbf884e41a336271a0d654e785953b44b)

Did I do something the wrong way?

@hamstah
Copy link
Owner

hamstah commented Dec 8, 2016

Hi,

I don't think you've done anything wrong.
It looks like the test might be out of date and you should be ok using it.
There have been a few changes since the first commit which had the test.
I'll have a look when I get some time.

Thanks

@deogracia
Copy link
Author

OK.

Thanks for your work :D

@langston-barrett
Copy link

It looks like there's been a PR related to this issue, but there hasn't been a new version uploaded to PyPI.

@hamstah
Copy link
Owner

hamstah commented Jul 3, 2017

Hi,
I've updated Pypi with master just now.
Sorry for the delay in updating it, got busy and completely forgot!

@hamstah hamstah closed this as completed Jul 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants