We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
After the update the to openweathermap API, the /weather endpoint is not working. I think the reason is due to weather url.
/weather
In application.properties it is defined as:
application.properties
weather.url = https://api.openweathermap.org/data/2.5/weather
And it is called in WeatherClient.java as:
WeatherClient.java
var url = String.format("%s/data/2.5/weather?q=%s&appid=%s", weatherServiceUrl, CITY, weatherServiceApiKey);
The part /data/2.5/weather will be duplicated. A simple fix is to define it in application.properties as:
/data/2.5/weather
weather.url = https://api.openweathermap.org
After fixing it, the existing tests and the /weather endpoint were working for me.
By the way, is /src/main/resources/application-int.properties still used? It still contains a reference to the darksky API.
/src/main/resources/application-int.properties
The text was updated successfully, but these errors were encountered:
Thanks for spotting! These are indeed two distinct issues and I just fixed both of them:
application-int.properties
weather.url
Sorry, something went wrong.
No branches or pull requests
After the update the to openweathermap API, the
/weather
endpoint is not working. I think the reason is due to weather url.In
application.properties
it is defined as:weather.url = https://api.openweathermap.org/data/2.5/weather
And it is called in
WeatherClient.java
as:var url = String.format("%s/data/2.5/weather?q=%s&appid=%s", weatherServiceUrl, CITY, weatherServiceApiKey);
The part
/data/2.5/weather
will be duplicated. A simple fix is to define it inapplication.properties
as:weather.url = https://api.openweathermap.org
After fixing it, the existing tests and the
/weather
endpoint were working for me.By the way, is
/src/main/resources/application-int.properties
still used? It still contains a reference to the darksky API.The text was updated successfully, but these errors were encountered: