Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with nested requirements #15

Closed
trsh opened this issue Aug 18, 2018 · 7 comments
Closed

Problems with nested requirements #15

trsh opened this issue Aug 18, 2018 · 7 comments
Labels
enhancement New feature or request help wanted Extra attention is needed no-issue-activity

Comments

@trsh
Copy link

trsh commented Aug 18, 2018

Issue type

I'm submitting a (check one):
[ x] Bug report
[x ] Feature request
[ ] Regression (something that used to work, but stopped working in a newer version)
[ ] Support request
[ ] Documentation issue or request

Prerequisites

Before posting, make sure you do the following (check all):
[x ] Confirm you are using the latest versions of all necessary packages (or if not, explain why not)

Current behavior

When you have parent property, that isn't required, but has self required properties, it gives an error. I don't know how to solve this. https://json-editor.github.io/json-editor/ fro example, has optional objects as initially non listed and addable. So when you add the object, it's properties are required, but can also skip the whole object, as it is optional.

@hamzahamidi
Copy link
Owner

hamzahamidi commented Aug 30, 2018

Sorry for the late reply, can you make a repository or give the JSON schema to reproduce this issue?

@trsh
Copy link
Author

trsh commented Aug 31, 2018

https://gist.githubusercontent.com/trsh/b710a2ed982c4064c06c4d0fae7cd5e4/raw/a5fedce98aa2647e2e40b621eb5ddaada2631352/json

The default behavior should be that I do not get any errors about 'y', as I can skip whole 'x' object (unless I chose to USE it), as IT is not required.

Ideally not required objects/whatever should be Hidden by default, and addable visa some checkbox.

If you check https://json-editor.github.io/json-editor/ -> Location -> Properties, u will see the idea.

@trsh
Copy link
Author

trsh commented Sep 2, 2018

@hamzahamidi ?

@hamzahamidi
Copy link
Owner

Still looking at this problem but I'm not sure what causes it!

@trsh
Copy link
Author

trsh commented Sep 5, 2018

@hamzahamidi I think ppl just haven't tough about this scenario?

@hamzahamidi hamzahamidi added bug Something isn't working help wanted Extra attention is needed labels Oct 13, 2018
@hamzahamidi hamzahamidi added enhancement New feature or request and removed bug Something isn't working labels Feb 10, 2019
@bradley-redford
Copy link

Any update on this issue ?

@github-actions
Copy link

github-actions bot commented Apr 4, 2020

Stale issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed no-issue-activity
Projects
None yet
Development

No branches or pull requests

3 participants