Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Color Names #16

Closed
hamzaolak opened this issue Oct 14, 2019 · 6 comments
Closed

Change Color Names #16

hamzaolak opened this issue Oct 14, 2019 · 6 comments
Labels
good first issue Good for newcomers Task Task Create
Projects
fast-read

Comments

@hamzaolak
Copy link
Owner

PrimaryColor
PrimaryDarkColor
SecondaryColor
SecondaryDarkColor
TextColor
DescriptionTextColor
MarkedColor
@hamzaolak hamzaolak added good first issue Good for newcomers Task Task Create labels Oct 14, 2019
@hamzaolak hamzaolak added this to To do in fast-read via automation Oct 14, 2019
@cheiaych
Copy link

Did you want to change the color names in theme.js to these names in the same order?

@cheiaych cheiaych mentioned this issue Oct 14, 2019
Closed
@hamzaolak
Copy link
Owner Author

hamzaolak commented Oct 15, 2019 •
edited

primaryColor: "#E1D5E7",
primaryDarkColor: "#9673A6",
secondaryColor: "#D5E8D4",
secondaryDarkColor: "#82B366",
textColor: "#1A1A1A",
descriptionTextColor: "#4D4D4D",
hoverColor: "FBFBFB",
markedColor: "#CC0000"
https://drive.google.com/file/d/1p81xdwYsmJvKX7pjuL8Jg11XefAq83LI/view?usp=sharing
project designs

@cheiaych
Copy link

Alright I changed the values.
The changes are in pull request #18

@hamzaolak
Copy link
Owner Author

I write command your pr if you want we can open slack channel or you can write in whatsapp +905388274256

@cheiaych
Copy link

I only worked on this issue for an assignment so I probably won't be making any more contributions after this issue.

@hamzaolak
Copy link
Owner Author

Okay I commented your pull request

@hamzaolak hamzaolak moved this from To do to In progress in fast-read Oct 28, 2019
@hamzaolak hamzaolak moved this from In progress to Done in fast-read Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers Task Task Create
Projects
fast-read
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hamzaolak @cheiaych