Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Color Names #16

Closed
hamzaolak opened this issue Oct 14, 2019 · 6 comments
Closed

Change Color Names #16

hamzaolak opened this issue Oct 14, 2019 · 6 comments

Comments

@hamzaolak
Copy link
Owner

@hamzaolak hamzaolak commented Oct 14, 2019

PrimaryColor
PrimaryDarkColor
SecondaryColor
SecondaryDarkColor
TextColor
DescriptionTextColor
MarkedColor

@hamzaolak hamzaolak added this to To do in fast-read via automation Oct 14, 2019
@jordanhui19

This comment has been minimized.

Copy link

@jordanhui19 jordanhui19 commented Oct 14, 2019

Did you want to change the color names in theme.js to these names in the same order?

@hamzaolak

This comment has been minimized.

Copy link
Owner Author

@hamzaolak hamzaolak commented Oct 15, 2019

primaryColor: "#E1D5E7",
primaryDarkColor: "#9673A6",
secondaryColor: "#D5E8D4",
secondaryDarkColor: "#82B366",
textColor: "#1A1A1A",
descriptionTextColor: "#4D4D4D",
hoverColor: "FBFBFB",
markedColor: "#CC0000"
https://drive.google.com/file/d/1p81xdwYsmJvKX7pjuL8Jg11XefAq83LI/view?usp=sharing
project designs

@jordanhui19

This comment has been minimized.

Copy link

@jordanhui19 jordanhui19 commented Oct 15, 2019

Alright I changed the values.
The changes are in pull request #18

@hamzaolak

This comment has been minimized.

Copy link
Owner Author

@hamzaolak hamzaolak commented Oct 15, 2019

I write command your pr if you want we can open slack channel or you can write in whatsapp +905388274256

@jordanhui19

This comment has been minimized.

Copy link

@jordanhui19 jordanhui19 commented Oct 16, 2019

I only worked on this issue for an assignment so I probably won't be making any more contributions after this issue.

@hamzaolak

This comment has been minimized.

Copy link
Owner Author

@hamzaolak hamzaolak commented Oct 16, 2019

Okay I commented your pull request

@hamzaolak hamzaolak moved this from To do to In progress in fast-read Oct 28, 2019
@hamzaolak hamzaolak moved this from In progress to Done in fast-read Oct 28, 2019
@hamzaolak hamzaolak closed this Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
fast-read
  
Done
2 participants
You can’t perform that action at this time.