Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GS Guide: Hanami 1.2 test count is different #444

Open
radar opened this issue Mar 1, 2018 · 1 comment
Open

GS Guide: Hanami 1.2 test count is different #444

radar opened this issue Mar 1, 2018 · 1 comment

Comments

@radar
Copy link
Sponsor Contributor

radar commented Mar 1, 2018

Right before the section in the GS guide called "Building Forms To Create Records", there's some test output shown:

9 runs, 16 assertions, 0 failures, 0 errors, 0 skips

This test output has changed in v1.2 to:

12 runs, 20 assertions, 0 failures, 0 errors, 0 skips

I guess there have been some new tests added in the interim?


I am submitting this as an issue and not a PR because I couldn't find a 1.2-specific getting started guide at the moment.

@cllns
Copy link
Member

cllns commented Mar 1, 2018

👍 Thanks! With #429 we're working on converting the Getting Started guide to use RSpec instead of MiniTest. In that process, we're going through and updating the test outputs, since they look different with RSpec, too.

That should be live before 1.2.0 (It's really 100% my fault if it's not...).

This is likely the cause: hanami/hanami#860 . Before we had a skip, but now there's a real expectation being made, which causes this discrepancy.

That PR was also shipped in 1.1.1, which was released yesterday. If you (or anyone else) wants to open a PR with this change against the 1.1 guides, that'd be great. 🌸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants