Label form helper errors when provided a symbol

[dcr8898]

Summary

When provided a symbol argument, the label form helper produces an error.

Expected behavior

I'm not sure what the correct actual behavior is, so this may not be an issue at all. In all of the examples in the API docs, and in the unpublished guide, for form_for and its related helpers, all of the name/content method arguments are shown as strings. However, I noticed that some of the tests (notably the fields_for_collection tests) use symbol arguments.

If symbols are acceptable arguments, then label does not currently parse them correctly.

When the following erb template is used:

<%= form_for("/books") do |f| %>
  <%= f.label :free_shipping %>
<% end %>

It should produce:

<label for="free-shipping">Free shipping</label>

Actual behavior

Instead, an error is produced:

undefined method `split' for :free_shipping:Symbol

Discussion

If symbols should be accepted as the content argument to the label form helper, the accompanying pull request includes a fix.