Update master #165
Merged
Update master #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@PascalPiche came across this bug while displaying the weekday name: The DS formats the weekday with 'N', which uses ISO-8601 (first date of the week is then Monday as in the US, not Sunday). There were multiple places where a fix could be applied, but the best solutions we found was to apply the fix in the data-source for two reasons: 1. Field ouput won't change, so less risk to break things 2. The xsl template is agnostic to this change since it was doing string matches
@nitrique: Are you interested in updating this extension to 2.6? We are currently not using it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.