Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kirby 4: discontinue this plugin? #36

Open
nilshoerrmann opened this issue Sep 28, 2023 · 2 comments
Open

Kirby 4: discontinue this plugin? #36

nilshoerrmann opened this issue Sep 28, 2023 · 2 comments
Assignees
Labels
question Further information is requested

Comments

@nilshoerrmann
Copy link
Member

nilshoerrmann commented Sep 28, 2023

The development of Kirby 4 is getting along and there finally will be a core color field. It works differently in some parts, yes, but it does what you'd expect from a color field. So the question is: Are there parts that the core will not offer that are widely required that justify continued work on the plugin?

For our studio, checking contrast is the essential part but this could be done via a separate field.

So, if you have been using this field could you please react to this issue with a:

  • 👎 for discontinuing the plugin
  • 👍 for keeping this plugin

If you vote for updating this plugin, please add a comment what you are using the field for that the core does not offer.
Thanks ❤️

@nilshoerrmann nilshoerrmann changed the title Kirby 4: deprecate this plugin? Kirby 4: discontinue this plugin? Sep 28, 2023
@tobimori
Copy link

Although this might be out of the scope of this plugin specifically, a new plugin that does the following would definitely solve some of my needs:

  • Extend built-in field and allow for key storage for palette (so don't store #fff, but store white)
  • Continue to provide helper classes (->toColor()) for e.g. converting between color spaces.
  • Add contrast checking (would be great especially w/ WCAG 3 / APCA contrast checking #30)
  • Add options query syntax (set colors in a structure and then use them in a color palette field later via queries)

@nilshoerrmann
Copy link
Member Author

I think two of your points should be added to the core field:

  • Extend built-in field and allow for key storage for palette (so don't store #fff, but store white)
  • Add options query syntax (set colors in a structure and then use them in a color palette field later via queries)

The other two points, we are interested in as well:

  • Continue to provide helper classes (->toColor()) for e.g. converting between color spaces.
  • Add contrast checking (would be great especially w/ WCAG 3 / APCA contrast checking #30)

Maintaining a PHP port of APCA-W3 seems like a nightmare because of their wild license requirements to follow suit any update to their core algorithm. Also their naming (or not naming) requirements are complicated. That's why we stepped back from adding APCA to this plugin so far. But it might be an idea to rely on an external library for this. Colori might be interesting: https://github.com/Remiscan/colori

As I wrote above, we are very much interested in keeping contrast checks available as plugin. And converting and manipulating colors fits in there as well.

@nilshoerrmann nilshoerrmann added the question Further information is requested label Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants