New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

代码复审建议 #1

Open

Slontia opened this issue Oct 2, 2017 · 0 comments

Slontia commented Oct 2, 2017

建议将一些有关行列计算部分的代码define一下，比如根据行列号得出宫号等；
适当增添一些注释，可以考虑给一个类的Overview并对其成员的意义进行说明；
被注释掉的代码有些多，建议删一下……

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment