Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Background threads do not terminate when using native callback #18

Closed
hanazuki opened this issue Jan 7, 2021 · 2 comments
Closed

Background threads do not terminate when using native callback #18

hanazuki opened this issue Jan 7, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@hanazuki
Copy link
Owner

hanazuki commented Jan 7, 2021

The following program must terminate:

const { Jsonnet } = require("@hanazuki/node-jsonnet");
const jsonnet = new Jsonnet();
jsonnet.nativeCallback("id", (x) => x, "x");
@hanazuki
Copy link
Owner Author

hanazuki commented Jan 7, 2021

Bisect suggests bdd90a5 as the first bad commit

@hanazuki
Copy link
Owner Author

Fixed in a5ae189

@hanazuki hanazuki changed the title Background threads do not terminate when using native callback. Background threads do not terminate when using native callback Feb 5, 2021
@hanazuki hanazuki added the bug Something isn't working label Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hanazuki