Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove network from options passed to NodeClient and WalletClient #92

Closed
pinheadmz opened this issue Jan 5, 2021 · 0 comments · Fixed by #99
Closed

remove network from options passed to NodeClient and WalletClient #92

pinheadmz opened this issue Jan 5, 2021 · 0 comments · Fixed by #99

Comments

@pinheadmz
Copy link
Member

pinheadmz commented Jan 5, 2021

This is kind of an amazing oversight, but NodeClient and WalletClient actually do no parse network as options. The command line utilities (like hsd-cli) do, but then the CLI program itself just parses that to determine which port setting to pass the actual client object.

All the JavaScript examples in the API docs can be updated to remove these from the options:

  network: network.type,

In addition, the line can be cleared out from the "Using Javascript Clients" section.

This change should be backported to bcoin docs as well: https://github.com/bcoin-org/bcoin-org.github.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant