Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When to use HNS vs dollarydoos #95

Closed
pinheadmz opened this issue Jan 27, 2021 · 2 comments
Closed

When to use HNS vs dollarydoos #95

pinheadmz opened this issue Jan 27, 2021 · 2 comments

Comments

@pinheadmz
Copy link
Member

Note the message here: https://hsd-dev.org/api-docs/#create-a-transaction

Be careful how you enter values and fee rates!
value and rate are expressed in subunits when using cURL or Javascript
value and rate are expressed in WHOLE HNS when using CLI
Watch carefully how values are entered in the examples, all examples send the same amount when executed

This is a big issue with the API -- between RPC and HTTP APIs, and then using CLI commands vs curl or JS... developers can get really screwed up.

We need a big explainer in the "intro" section at the top of the api-docs, maybe with a chart, that lays out when and where and why which unit is used for which methods. We don't want developers entering 1000000 and accidentally sending 1,000,000 HNS when they think they're just sending 1.000000 HNS !

This applies to all fee settings and value settings in transaction stuff. Probably throughout the API docs the new intro message should be linked-to for reference.

@randomlogin
Copy link
Contributor

#101

@pinheadmz
Copy link
Member Author

closed 93266f4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants