Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof fields not used. #8

Open
davebryson opened this issue Sep 4, 2018 · 1 comment
Open

Proof fields not used. #8

davebryson opened this issue Sep 4, 2018 · 1 comment

Comments

@davebryson
Copy link

proof.isSane() checks for nil values for the type deadend. Is there even a need for this? Looking through the code it appears there's no possible way for key,value,hash to ever be set for deadend. Is it simply good enough to check for the type without testing the unused fields? Or are these fields placeholders for future reference?

@chjj
Copy link
Contributor

chjj commented Sep 30, 2018

Yeah, the serialization enforces most of the checks in isSane() already. A lot of the sanity checks are just there on account of my paranoia.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants