New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onKeyDown questions #17

Closed

warpech opened this issue Jun 14, 2012 · 1 comment

Labels

bug Status: Released

Member

warpech commented Jun 14, 2012

it's awesome plugin and very useful

i have some questions

I think this condition "if (!priv.isCellEdited)" must cover below codes
case 36: /* home / ...
case 35: / end */ ...
why you don't check this keys '"[]\ ( keycode : 219 ~ 222) in function onKeyDown
is there some reason?

Member Author

warpech commented Jun 14, 2012

Thanks @kimwz, your both comments were very rational. I made the changes to the code. Do you have any more comments?

warpech closed this as completed

AMBudnik added bug Status: Merged (ready for release) labels

AMBudnik added Status: Released and removed Status: Merged (ready for release) labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment