Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Validation of potential values still takes place when changes are cancelled #3381
When changes are cancelled inside
Here's a jsfiddle: http://jsfiddle.net/kpccz12k/1/
In that jsfiddle, if you copy the cells for the top table and paste them into the second table, you'll see that the values do not change because we
Validation based on the new values should be prevented if the changes are cancelled.
referenced this issue
Apr 13, 2016
@AMBudnik I agree, the two seem related. That's exactly what I changed in my PR. I took the
@AMBudnik to add more detail on the negative effects of this, we're cancelling a large multi-row paste in one table and instead triggering that paste into a second table for editing/correction before incorporating the data back into the first. This bug means that validation of these cancelled values does take place in the original table, marking tons of cells as invalid when nothing has changed. If the paste is larger than the original table rows are even added, apparently to give these false validations a place to land. It's also effecting the performance of opening up the second table, because the full validation routine runs once (incorrectly), then we have to re-validate to clear the bad validation. That's two full runs through validation before we can even open the second table, which has its own validations. We've got some pretty complex custom validations happening, so this triplicate validation for a paste is really taking a toll.