Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox/beforeChange: define a change source #3539

Closed
AMBudnik opened this issue May 25, 2016 · 5 comments
Closed

Checkbox/beforeChange: define a change source #3539

AMBudnik opened this issue May 25, 2016 · 5 comments

Comments

@AMBudnik
Copy link
Contributor

Checkbox checking/unchecking returns

  1. edit source in afterChange callback and
  2. undefined in beforeChange callback

Demo: http://jsfiddle.net/zajxagm3/
I guess that we have to add a source for beforeChange when a user uses checkbox.

@AMBudnik
Copy link
Contributor Author

the same case relates to an action when you delete a content from a cell. http://jsfiddle.net/njr3tcx0/

change

@AMBudnik
Copy link
Contributor Author

AMBudnik commented Jan 23, 2017

Still undefined in v0.30.1, demo: http://jsfiddle.net/handsoncode/cLn0pzhg/

@gmanoj26
Copy link

gmanoj26 commented Feb 15, 2018

@AMBudnik
we are facing similar issue while migrating handson library version from 0.10.5 to 0.35.1.
Making below change in handsontable.full.js (line no: 15150) solved the issue.code change made is similar to the existing code of after change event
image

note: we have verified before change source for other events. before change is returning correct source value for below events
"CopyPaste.paste"
"UndoRedo.undo"
"UndoRedo.redo"
"Autofill.fill"

i hope this solves the bug....

@AMBudnik
Copy link
Contributor Author

Thank you for sharingthe tips @gmanoj26

@AMBudnik
Copy link
Contributor Author

Hi @gmanoj26

We have done some fixes. Please update the code to 0.38.0 and check if it works for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants