Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular reference error in the formula #4357

Closed
ssbunny opened this issue Jun 30, 2017 · 12 comments
Closed

Circular reference error in the formula #4357

ssbunny opened this issue Jun 30, 2017 · 12 comments

Comments

@ssbunny
Copy link

ssbunny commented Jun 30, 2017

Description

If there is a circular reference in the formula plugin, the page hangs because it will cause a Maximum call stack size exceeded error.

Steps to reproduce

  1. let A1 = 1, B1 = 1, A2 = =A1+B1;
  2. After hot rendered, dblclick B1, set the value to =A2.

Demo

https://jsfiddle.net/ssbunny/a1pLraxz/

Your environment

  • Handsontable version: pro 1.11.0
  • Browser Name and version: Safari 9.0.2
  • Operating System: OS X 10.11.2
@AMBudnik
Copy link
Contributor

Thank you show sharing @ssbunny

I have replicated the issue. [GL #93]

@AMBudnik
Copy link
Contributor

It works the same in v 5.0.0

@OlgaIOn
Copy link

OlgaIOn commented Apr 14, 2020

@AMBudnik is there any update on the issue? Can we have an ETA on this?
Will this be solved in a new formula plugin? Thanks in advance!

@AMBudnik
Copy link
Contributor

Hey @OlgaIOn the new formula plugin is based on a different calculating engine and the connector (the code that helps the engine to work with Handsontable) is built from a scratch.

The circular reference issue may now be replicable in the new plugin. However, as it is still a work in progress we need to keep all those formula issues in one place and test them after development.

@OlgaIOn
Copy link

OlgaIOn commented Apr 15, 2020

@AMBudnik, thanks for your reply. We are waiting impatiently for the new formula plugin, since formulas are essential for our needs. When it will be ready?

@AMBudnik
Copy link
Contributor

@OlgaIOn I highly encourage you to track progress on that topic #6466 and here is a full list of issues related to the formula engine.

@AMBudnik AMBudnik added the Part of scope This issue is a part of a larger task label Feb 11, 2021
@AMBudnik
Copy link
Contributor

This issue is closed temporarily. It will be reopened for development as it became a part of New formula plugin task reported at #6466

I will make sure to inform everyone interested in this topic after the official fix.

Please feel welcome to makes any comments on this issue. And if you experience similar behavior feel free to contact me at support@handsontable.com

@aninde
Copy link
Contributor

aninde commented May 21, 2021

Updated demo
Bug reproducible with current v8.4.0 (https://jsfiddle.net/aninde/n49y86po/)

handsontable.full.js:14784 Uncaught RangeError: Maximum call stack size exceeded

Behavior is different on currently tested v9.0.0 with HyperFormula as engine (https://jsfiddle.net/aninde/o953u7c8/)
Table returns #CYCLE error due to handsontable/hyperformula#362.

Screenshot 2021-05-21 at 11 05 27

@wojciechczerniak
Copy link
Contributor

@aninde as it should 👍

@aninde
Copy link
Contributor

aninde commented May 21, 2021

@aninde as it should 👍

@wojciechczerniak so we consider it as a fix?

@wojciechczerniak
Copy link
Contributor

Yes

@AMBudnik
Copy link
Contributor

AMBudnik commented Jun 1, 2021

It works the same (#CYCLE error) in official v9. Updated demo https://jsfiddle.net/crbt4xoj/

@AMBudnik AMBudnik added Status: Released and removed Part of scope This issue is a part of a larger task labels Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants