Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo doesn't work for moving columns #4846

Closed
AMBudnik opened this issue Feb 27, 2018 · 8 comments
Closed

Undo doesn't work for moving columns #4846

AMBudnik opened this issue Feb 27, 2018 · 8 comments

Comments

@AMBudnik
Copy link
Contributor

Description

Undo doesn't work for moving columns

Steps to reproduce

  1. Move any column to any other position
  2. Use CTRL/CMD + Z

Result: Nothing changes.
Expected: The column should return to its first position.

Demo

http://jsfiddle.net/jrhumujk/

Your environment

  • Handsontable version: 0.36.0
  • Browser Name and version: Chrome 64
  • Operating System: Windows 10
@AMBudnik
Copy link
Contributor Author

AMBudnik commented Apr 5, 2018

The issue still replicable in v0.38.1 and did not work in any previous version either.

@AMBudnik
Copy link
Contributor Author

The same in v5.0.1 http://jsfiddle.net/8be3xkov/

@AMBudnik
Copy link
Contributor Author

The CTRL/CMD + Z doesn't trigger beforeUndo hook when we moved columns. It is also unavailable as an option for the context menu.

ps. for rows it works perfectly.

@aninde
Copy link
Contributor

aninde commented Oct 16, 2019

The bug is still replicable in 7.2.1 v.

Demo
7.2.1 v. http://jsfiddle.net/aninde/4vm0pxh1/

@AMBudnik
Copy link
Contributor Author

To complete the subject I wanted to add that the undoRedo plugin is able to undo movement of rows but it doesn't do the same for columns.
Updated demo http://jsfiddle.net/AMBudnik/an32tx07/ (8.0.0-beta1)

UndoRedo has many missing pieces of description, but we should keep consistency between operations on rows and columns so I call it a bug.

@pnowak
Copy link
Contributor

pnowak commented Aug 26, 2020

This issue is still replicable using v8.0.0. Here's an updated demo - https://jsfiddle.net/buwhyokq/

@AMBudnik
Copy link
Contributor Author

AMBudnik commented Feb 4, 2021

This issue is closed temporarily. It will be reopened for development as it became a part of Interoperability problems between UndoRedo and some core features task reported at #7508

I will make sure to inform everyone interested in this topic after the official fix.

Please feel welcome to makes any comments on this issue. And if you experience similar behavior feel free to contact me at support@handsontable.com

@AMBudnik
Copy link
Contributor Author

AMBudnik commented Mar 6, 2024

Issue update: This functionality was introduced in Handsontable v14.2.0.

Please check this PR for reference. #10746

@AMBudnik AMBudnik added Status: Released and removed Part of scope This issue is a part of a larger task labels Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants