Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter as you type #5030

Closed
aaronbeall opened this issue Apr 13, 2018 · 4 comments
Closed

Filter as you type #5030

aaronbeall opened this issue Apr 13, 2018 · 4 comments

Comments

@aaronbeall
Copy link
Contributor

Description

The default behavior of filter_by_value is that when you type in the search value it does not filter anything. You have to press "Clear" first, then search, then filter. I know this is the behavior of Google Sheets but it has come up in user testing as confusing. Excel, by contrast, will filter out items immediately as you type -- basically it automatically deselects items that don't match what you've searched for. Is there a way to modify the filter_by_value to behave this way to implement a filter_by_search that does this?

Steps to reproduce

  1. Turn on filter_by_value
  2. Open dropdown, enter search term, press OK
  3. No filter is applied

Demo

http://jsfiddle.net/upo1uLgs/

Your environment

  • Handsontable version: pro-1.18.1
  • Browser Name and version: Chrome 65
  • Operating System: MacOS High Sierra
@AMBudnik
Copy link
Contributor

Hi,

yes, that is an intended behavior as all the data is visible in the table they are also visible/checked in the filter_by_value list.

If you would like to clear the values here's how to do it http://jsfiddle.net/handsoncode/3gz93neb/ but still, you'll need to check the checkbox of a searched/result query.

3gif

I will add this topic to the feature request list. Thanks for sharing the idea @aaronbeall

@aaronbeall
Copy link
Contributor Author

aaronbeall commented Apr 16, 2018

Thanks. That's pretty close but if you don't interact with the filter and press OK then it actually clears everything.

The desired behavior would be like Excel:
img

Even if it didn't update the filter live and you still had to press OK to apply the filter, the main difference is that if you type a search value it automatically down-filters to items that match the search value. This is a lot easier to use that the current implementation, which we got confused feedback from users during testing (users who are used to Excel).

It'd be awesome if there was an option that made the filter_by_value do the same "deselect unmatched values" would be really useful.

@AMBudnik
Copy link
Contributor

That is definitely a cool idea. There's something similar here http://jsfiddle.net/rjb9p8b3/ when we use column headers.

@AMBudnik
Copy link
Contributor

AMBudnik commented Dec 7, 2018

As mentioned in the #5424 I am temporarily closing this issue

@AMBudnik AMBudnik closed this as completed Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants