Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.4.1+] afterGetColHeader returns false for col parameter if columnSorting is enabled for nestedHeaders #5071

Closed
AMBudnik opened this issue Apr 30, 2018 · 1 comment
Labels
bug Column sorting Plugin Core: Callbacks Plugin Nested headers Plugin Regression Issues that were created while adding new changes to the source code

Comments

@AMBudnik
Copy link
Contributor

AMBudnik commented Apr 30, 2018

Description

afterGetColHeader hook returns false for col parameter (1st) if columnSorting plugin is enabled for nestedHeaders functionality.

Steps to reproduce

  1. Just check the console for logs of the col index.
  2. Uncomment the 37 line (columnSorting: true).

Result: The -1 index becomes false.

Demo

http://jsfiddle.net/0rtaL5jd/ 1.5.0
(working 1.4.1 http://jsfiddle.net/Lcpdzy0x/)

Your environment

  • Handsontable version: 1.5.0+
  • Browser Name and version: Chrome 65
  • Operating System: Windows 10

Inform forum

@AMBudnik AMBudnik changed the title afterGetColHeader returns false for col parameter if columnSorting is enabled for nestedHeaders [1.4.1+] afterGetColHeader returns false for col parameter if columnSorting is enabled for nestedHeaders May 11, 2018
@AMBudnik AMBudnik added the Regression Issues that were created while adding new changes to the source code label May 11, 2018
@AMBudnik
Copy link
Contributor Author

AMBudnik commented Oct 2, 2018

The issue is no longer replicable. In v 6.0.1 we get -1 for both of the settings. Issue considered fixed

@AMBudnik AMBudnik closed this as completed Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Column sorting Plugin Core: Callbacks Plugin Nested headers Plugin Regression Issues that were created while adding new changes to the source code
Projects
None yet
Development

No branches or pull requests

1 participant