Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing stopPropagation(event); from dropdownMenu onTableClick method #5800

Closed
pnowak opened this issue Feb 19, 2019 · 1 comment
Closed

Consider removing stopPropagation(event); from dropdownMenu onTableClick method #5800

pnowak opened this issue Feb 19, 2019 · 1 comment
Labels
Dropdown menu Plugin Status: To be discussed Plugin Type: Improvement suggestion

Comments

@pnowak
Copy link
Contributor

pnowak commented Feb 19, 2019 •
edited

Description

This method is a listener for the whole table to click action and for that reason prevents modal dialog from opening.
Maybe Event.preventDefault is enough, or maybe both (stopPropagation and preventDefault) are useless and should be removed.

Steps to reproduce

Demo

Your environment

  • Handsontable version:
  • Browser Name and version:
  • Operating System:
@pnowak pnowak added the Dropdown menu Plugin label Feb 19, 2019
@AMBudnik
Copy link
Contributor

AMBudnik commented Feb 19, 2019 •
edited

Contact https://forum.handsontable.com/t/modal-dialog-does-not-open-with-dropdownmenu-enabled/2956/8 after adding the change.
Zen 24842

@pnowak pnowak changed the title Consider remove stopPropagation(event); from dropdownMenu onTableClick method Consider removing stopPropagation(event); from dropdownMenu onTableClick method Aug 12, 2020
@handsontable handsontable locked and limited conversation to collaborators Apr 15, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Assignees
No one assigned
Labels
Dropdown menu Plugin Status: To be discussed Plugin Type: Improvement suggestion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pnowak @AMBudnik @mrpiotr-dev