Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minSpareRows does not appear if we set at least one row as trimmed #5862

Closed
Tracked by #5751 ...
AMBudnik opened this issue Feb 12, 2019 · 5 comments
Closed
Tracked by #5751 ...

minSpareRows does not appear if we set at least one row as trimmed #5862

AMBudnik opened this issue Feb 12, 2019 · 5 comments

Comments

@AMBudnik
Copy link
Contributor

Description

reported https://forum.handsontable.com/t/gl-161-minsparerows-after-changing-trimrows/1139/2
GL #161


minSpareRows does not appear if we set at least one row as trimmed

Steps to reproduce

  1. Check the demo. You should see one empty row (spare).

Demo

http://jsfiddle.net/handsoncode/styq17m0/

Your environment

  • Handsontable version: 6.2.2
  • Browser Name and version: Chrome 71
  • Operating System: Windows 10
@AMBudnik AMBudnik transferred this issue from handsontable/handsontable-pro Mar 11, 2019
@AMBudnik
Copy link
Contributor Author

AMBudnik commented Apr 5, 2019

The table does not load an additional row but the headers are cut. If we scroll up and down the border is added.

Zrzut ekranu 2019-04-5 o 11 50 36

This works the same in v 7.0.0.
Is does not matter how many rows do we trim and how many rows are in the minSpareRows. Enabling the plugin trimRows: true, works well (doesn't produce any issues).

The rows + spare rows are back when we disable the plugin.

hot.updateSettings({
	trimRows: false
})

@AMBudnik
Copy link
Contributor Author

The issue does not change in v 8.0.0.-rc1
Updated demo http://jsfiddle.net/handsoncode/nxre7jf9/
The spare row is still missing.

@AMBudnik
Copy link
Contributor Author

AMBudnik commented Sep 20, 2019

Fixed with 8.0.0-rc1-beta2
Updated demo http://jsfiddle.net/Lqnhv6fd/
Zrzut ekranu 2019-09-20 o 14 43 13

@AMBudnik
Copy link
Contributor Author

Solved with the official version 8.0.0.-beta1 http://jsfiddle.net/0jmx6t3o/

@wojciechczerniak wojciechczerniak mentioned this issue Jan 23, 2020
204 tasks
@AMBudnik
Copy link
Contributor Author

AMBudnik commented Aug 7, 2020

Demo updated to v 8.0.0 http://jsfiddle.net/ygubq237/ Issue is solved. Thanks for fixing Team!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant