Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In iframe + firefox, clicking on the cell the 'page scroll to top' issue still exist #5910

Closed
vincent-cm opened this issue Mar 25, 2019 · 7 comments

Comments

@vincent-cm
Copy link

@AMBudnik @swistach Can you please reopen this bug (#5605), observed this bug did not fixed.
Reason: The jsfiddle used by your demo page has changed, jsfiddle is no longer using iframe. So even thought it is scrolling fine on Firefox, it should not indicate the bug fixed.

To Reproduce, open any Firefox browser

  1. Open this link https://www.w3schools.com/tags/tryit.asp?filename=tryhtml_iframe
  2. Copy and paste following code into body part of the left side editor, replace all content of body
<iframe src="https://www.w3schools.com/code/tryit.asp?filename=G2EPME2C1SQB" width="800" height="800">
</iframe>
  1. Click "run" inside the loaded iframe over the right preview pane
  2. Resize the browser height to make scrollbar appear, scroll down the content and click on one of the table cells.

Observed that the whole page scroll to top.

It is hard to reproduce since service like jsfiddle, cssbin are blocking iframe embedding and only can be run once. Once saved, it will add up a restricted header check and blocks the loading.

@AMBudnik
Copy link
Contributor

AMBudnik commented Mar 26, 2019

Thank you for creating a new issue. It will be much easier to track progress. The previous one already had a list of commits.

Can you attach a video? I am trying to replicate the issue on FF 66/ Windows 10 but it seems to work fine.

@AMBudnik AMBudnik added the bug label Mar 26, 2019
@wojciechczerniak
Copy link
Contributor

@vincent-cm We've got a PR #5891 ready. Maybe you can check it out?

@wojciechczerniak wojciechczerniak added this to the March 2019 milestone Mar 28, 2019
@vincent-cm
Copy link
Author

vincent-cm commented Mar 29, 2019

@AMBudnik please check the video below, just follow above reproduce step on macOS, also windows 10.
http://sendvid.com/uptzunuu

Also it is observed that in Chrome it is working fine on vision, but the scrollbar shaked a bit which looks like it will scroll to top but is pulled back

@AMBudnik
Copy link
Contributor

I was able to replicate the issue, thank for sharing the video @vincent-cm

@AMBudnik
Copy link
Contributor

AMBudnik commented Apr 8, 2019

Welcome back @vincent-cm

we've just pushed a new version of Handsontable - 7.0.0 where we fixed the issue.

Please update and check if it works for you as well.

@vincent-cm
Copy link
Author

@AMBudnik Can you fix this version on 6? As we raised the bug on a free version which should not close this issue as per License guide.

@wojciechczerniak
Copy link
Contributor

@vincent-cm No. It doesn't work this way. We're fixing bugs, adding features and releasing new version using the semver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants