Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters and trimRows plugins can't work simultaneously #5915

Closed
Tracked by #5751 ...
Samitier opened this issue Mar 26, 2019 · 7 comments
Closed
Tracked by #5751 ...

Filters and trimRows plugins can't work simultaneously #5915

Samitier opened this issue Mar 26, 2019 · 7 comments

Comments

@Samitier
Copy link

Description

The plugins filter and trimRows are incompatible and cannot work at the same time.

Steps to reproduce

  1. Initialize a table with the options filters: true and trimRows: [someRowIndex].
  2. If both options are specified, trimRows will not filter any row.

Demo

https://jsfiddle.net/dgmLat68/

Your environment

  • Handsontable version: 6.2.2
  • Browser Name and version: Chrome 72
  • Operating System: Windows 10
@AMBudnik
Copy link
Contributor

AMBudnik commented Mar 26, 2019

Thank you for sharing the issue. I have replicated the bug. When I comment out the filters trimRows hides the 4th row.

Related topics:
#4567
#5112

The issue doesn't seem to be connected to any version of Handsontable.

@vaibhavkumar-sf
Copy link

Yes, same is minSpareRows adds extra spare lines if we use with "trimRows: [],"

@AMBudnik
Copy link
Contributor

Issue fixed in 8.0.0-rc1
Updated demo https://jsfiddle.net/handsoncode/asjoku45/
Tested on Chrome 77 / Windows 10.

Previosuly

trimRows (trimRows: [4]) has blocked by filters (filters: true)

In 8.0.0-rc1

trimRows is able to work with filters plugin and the trimmed row is not visible on the table initial load

image

@AMBudnik
Copy link
Contributor

AMBudnik commented Nov 14, 2019

Hi @Samitier @vk-sourcefuse

We've just released version 8.0.0-beta1 where this issue is fixed https://jsfiddle.net/z6c14qgo/
As this is only a beta now we do not recommend using it on the production. However, we wanted to share the version for you to test so any comment highly appreciated 👍

inform forum

@vaibhavkumar-sf
Copy link

Thanks :)

@wojciechczerniak wojciechczerniak mentioned this issue Jan 23, 2020
204 tasks
@AMBudnik
Copy link
Contributor

AMBudnik commented Aug 6, 2020

@vk-sourcefuse already knows the good news, but @Samitier hasn't been notified yet that v 8.0.0 is now online and along with other 150+ other issues it solves this issue as well :-)
Updated demo https://jsfiddle.net/sk4dzyoL/

Feel free to leave some feedback.

@vaibhavkumar-sf
Copy link

Yes, Now
filters: true, trimRows: [4]
are working at same time. Thanks @AMBudnik for updating regarding this issue too 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants