Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Borders after insert row are not movedown #6063

Open
Tracked by #6274
lloydz opened this issue Jun 18, 2019 · 13 comments
Open
Tracked by #6274

Borders after insert row are not movedown #6063

lloydz opened this issue Jun 18, 2019 · 13 comments

Comments

@lloydz
Copy link

lloydz commented Jun 18, 2019

Description

Borders after insert row are not movedown.
issue

Steps to reproduce

  1. set borders of a certain cell
  2. insert row before this cell
  3. the borders are not move down

Demo

Your environment

  • Handsontable version: 6.2.2
  • Browser Name and version: chrome
  • Operating System: window7
@AMBudnik
Copy link
Contributor

Hey @lloydz

it seems to work fine here https://jsfiddle.net/sb7v0n61/
Can you share a demo?

@lloydz
Copy link
Author

lloydz commented Jun 18, 2019

@AMBudnik
i guess you may misunderstand my meaning.
I want the new added row with no borders, and the original borders move down by a row step.

issue2

@AMBudnik
Copy link
Contributor

Then you'd need to modify the customBorders array.
You may find the {row: 2, col: 2, left: { /*...*/ } notion an easier one in this case.

@lloydz
Copy link
Author

lloydz commented Jun 20, 2019

@AMBudnik ,

thanks for your reply.

there are 2 problems to modify the customBorders array after a row inserted:

  1. the hook 'afterCreateRow' seems triggered before row inserted, is there any other hook for this case?
  2. instance.updateSettings({customBorders: newconfigedArray}) won't work as expected evevytime, any other ways to rerender the table with new settings?

@lloydz
Copy link
Author

lloydz commented Jun 20, 2019

besides, insert a row or remove rows also impact on the fomular setting issue 4654, any solution about this issue? thanks~

@AMBudnik
Copy link
Contributor

We are working on a new formula engine so all the issues related to formulas haven't been scheduled but if you could share your recent progress (perfectly by the JSFiddle) I will check the hooks.

@AMBudnik
Copy link
Contributor

AMBudnik commented Jul 1, 2019

Hey @lloydz

could you share your recent progress? Any news here?

@MitchVL
Copy link

MitchVL commented Jul 11, 2019

Is this being worked on ? We are currently testing hot to see if it suits our needs, and this bug is the only thing stopping us from purchasing, since it is essential for our needs.
Just like lloydz mentioned, the suggested solution does not work.

Handsontable version: 7.1.0
Browser Name and version: Chrome and Firefox
Operating System: windows 10

@AMBudnik
Copy link
Contributor

Hey @MitchVL I'm waiting for @lloydz code to check what we can do.

If you have a similar situation please send me the example at support@handsontable.com

@AMBudnik
Copy link
Contributor

The behavior does not change after updating to 8.0.0.-rc1

@aninde
Copy link
Contributor

aninde commented Dec 16, 2019

Works the same with a new version of cell meta feature/issue-6233.

Demo 7.2.2-feature/issue-6233 https://jsfiddle.net/aninde/a2s6d7ef/1/ - no fixed

@AMBudnik
Copy link
Contributor

Works the same in 8.0.0-beta1 https://jsfiddle.net/AMBudnik/kwauxpsL/ and in Google Sheets the border is moving with the cells so that is a bug.

@AMBudnik
Copy link
Contributor

It works the same in v8.2.0 https://jsfiddle.net/handsoncode/h3529mzq/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants