Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0.0.-beta2-rev2] Filter by value list is blank if we pick Filter by condition after choosing a value from Filters. #6861

Closed
AMBudnik opened this issue May 11, 2020 · 3 comments
Assignees
Labels
bug Filtering Plugin Regression Issues that were created while adding new changes to the source code

Comments

@AMBudnik
Copy link
Contributor

AMBudnik commented May 11, 2020

Description

Filter by value list is blank if we pick Filter by condition after choosing a value from Filters.

Might be related to #6497

Steps to reproduce

  1. Go to column C
  2. Scroll Filter by value to exclude C8 (do not click OK)
  3. Open Filter by condition list
  4. Pick 'Is empty'

Result
The list of values in the Filter by value is gone.
beta2

Demo

https://jsfiddle.net/bjrpvcet/ 8.0.0.-beta1 (working)
https://jsfiddle.net/hzk0bop9/ 8.0.0.-beta2-rev3 (broken)

Additional info

  • issue is not replicable if we do not scroll the filter by value list at first (here to find C8). We do not need to pick C8 to test it.

Your environment

  • Handsontable version: 8.0.0.-beta2-rev2
  • Browser Name and version: Chrome 80
  • Operating System: macOS Catalina
@AMBudnik AMBudnik added bug Filtering Plugin Regression Issues that were created while adding new changes to the source code labels May 11, 2020
@AMBudnik AMBudnik assigned AMBudnik and wszymanski and unassigned AMBudnik May 12, 2020
@AMBudnik
Copy link
Contributor Author

Works the same in 8.0.0-beta2-rev8 https://jsfiddle.net/AMBudnik/fL3p89qo/

@wojciechczerniak
Copy link
Contributor

@AMBudnik @aninde I don't see it on the regression list. What's the status here?

@wojciechczerniak wojciechczerniak mentioned this issue Jul 1, 2020
204 tasks
@AMBudnik
Copy link
Contributor Author

AMBudnik commented Jul 2, 2020

Before (issue) the list of filter_by_value was empty, until we scrolled.

Zrzut ekranu 2020-07-2 o 11 17 23

However, now (8.0.0-beta2-rev18) it is working as expected

solved

I would remove it from the 8.0.0 release epic as this was a regression. What we should do it is to add it to the 'Test for beta2' on /quality repository and close it as solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Filtering Plugin Regression Issues that were created while adding new changes to the source code
Projects
None yet
Development

No branches or pull requests

3 participants