Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.0.0-beta2-rev7] Clicking on corner doesn't select all cells and view is shifted #6915

Closed
aninde opened this issue May 21, 2020 · 2 comments
Closed

[8.0.0-beta2-rev7] Clicking on corner doesn't select all cells and view is shifted #6915

aninde opened this issue May 21, 2020 · 2 comments
Assignees
@jansiegel
Labels
bug Core: Selection Plugin Regression Issues that were created while adding new changes to the source code

Comments

@aninde
Copy link
Contributor

aninde commented May 21, 2020 •
edited

Description

We got 2 bugs here:

  1. Wrong view on the shifted table, similar to bugs introduced in iframe [8.0.0.-beta2-rev1] The view of the table moves when clicked LMB on the corner in iframe #6883 and after hiding all cells [8.0.0-beta2-rev1] rowHeaders are shifted after clicking on corner when every columns are hidden #6902.

  2. In this revision 7 clicking on corner select only first column, which is a regression compared to the operation of rev6 and previous versions 8.0.0-beta2. Only after the second click on corner, all cells can be selected.

rev7-corner

Steps to reproduce

  1. Open demo
  2. Click LMB on corner

Expected result:
Selection of all cells without shifting the view on the table.

Demo

https://codesandbox.io/embed/800-beta2-rev1-h2x03?codemirror=1 -v8.0.0-beta2-rev7(broken even worse)
https://codesandbox.io/embed/800-beta2-rev1-h2x03?codemirror=1 v8.0.0-beta2-rev.6 (broken)

Your environment

  • Handsontable version: [8.0.0-beta2-rev7]
  • Browser Name and version: Firefox 76, Chrome 81
  • Operating System: macOs Catalina 10.15
@aninde aninde added Core: Selection Plugin Regression Issues that were created while adding new changes to the source code labels May 21, 2020
@aninde aninde mentioned this issue May 21, 2020
Closed
@aninde aninde changed the title [8.0.0-beta2-rev7] Clicking on corner doesn't select all cells and view wrongly is shifted [8.0.0-beta2-rev7] Clicking on corner doesn't select all cells and view is shifted May 21, 2020
@aninde aninde added the bug label May 21, 2020
@jansiegel
Copy link
Member

Seems to be fixed with #6883.

@wszymanski wszymanski assigned jansiegel and unassigned wszymanski Jun 4, 2020
@aninde
Copy link
Contributor Author

aninde commented Jun 8, 2020

Solved by 8.0.0.-beta2-rev12 https://j7e4y.csb.app/
6915

@aninde aninde closed this as completed Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jansiegel jansiegel

Labels
bug Core: Selection Plugin Regression Issues that were created while adding new changes to the source code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wszymanski @jansiegel @aninde