Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.0.0-beta2-rev11] Moving resized row / selection on fixed, scrolled table causes errors #7049

Closed
aninde opened this issue Jun 24, 2020 · 2 comments
Closed

[8.0.0-beta2-rev11] Moving resized row / selection on fixed, scrolled table causes errors #7049

aninde opened this issue Jun 24, 2020 · 2 comments
Assignees
@budnix
Labels
bug Core: Selection Plugin Fixing / Freezing Plugin Regression Issues that were created while adding new changes to the source code Status: Released

Comments

@aninde
Copy link
Contributor

aninde commented Jun 24, 2020

Description

Fast scrolling and selection cause error in console when resizing and moving are enabled with fixed rows/columns.
This bug can be reproduced in two ways - Case 1 and Case 2.

TypeError: Cannot read property 'firstChild' of undefined in Chrome

Case 1
moving-resized

Case 2
scrolling-with-resize-move-fixed-enabled-chrome

Steps to reproduce

Case 1

  1. Resize the first row
  2. Try to move it to the end of the table only using a mouse, you want to scroll the table with this move.

Case 2

  1. Select the first column by clicking on its header
  2. Scroll down by trackpad (I used Magic Mouse) it cannot be reproduced without losing focus
  3. Click on the random cell

Demo

https://jsfiddle.net/uLa0qfke/ v.8.0.0-beta2-rev11 - broken
https://jsfiddle.net/1pjyrhmq/ v.8.0.0-beta2-rev16 - broken
https://jsfiddle.net/aninde/mxf1tqd5/ v7.4.2 - fixed
https://jsfiddle.net/aninde/Lgv03srb/. - v8.0.0-beta.1 - fixed

Your environment

  • Handsontable version: v.8.0.0-beta2-rev11+
  • Browser Name and version: Firefox 77, Chrome 83
  • Operating System: macOS Catalina 10.15.5
@aninde aninde added bug Freeze / Resize / Move Fixing / Freezing Plugin Core: Selection Plugin Regression Issues that were created while adding new changes to the source code labels Jun 24, 2020
@budnix budnix self-assigned this Jun 24, 2020
@aninde aninde mentioned this issue Jun 24, 2020
Closed
@budnix
Copy link
Member

budnix commented Jun 25, 2020 •
edited

The issue is fixed within PR #7044.

@budnix budnix mentioned this issue Jun 25, 2020
Merged
6 tasks
@aninde
Copy link
Contributor Author

aninde commented Jun 25, 2020

Both cases are solved with 8.0.0-beta2-rev17 https://jsfiddle.net/aninde/z4jevpt1/2/.

@aninde aninde closed this as completed Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@budnix budnix

Labels
bug Core: Selection Plugin Fixing / Freezing Plugin Regression Issues that were created while adding new changes to the source code Status: Released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@budnix @AMBudnik @aninde