Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTL] Comments #8822

Closed
Tracked by #8760
Siemienik opened this issue Oct 4, 2021 · 2 comments
Closed
Tracked by #8760

[RTL] Comments #8822

Siemienik opened this issue Oct 4, 2021 · 2 comments
Assignees
Labels

Comments

@Siemienik
Copy link
Contributor

Siemienik commented Oct 4, 2021

Description

For RTL, the comment icon should be displayed on the left and the comment dialog should open from right to left.

How to reproduce:

  1. Use this configuration:
{
    data: [
        ['', 'Tesla', 'Nissan', 'Toyota', 'Honda', 'Mazda', 'Ford'],
        ['2017', 10, 11, 12, 13, 15, 16],
        ['2018', 10, 11, 12, 13, 15, 16],
        ['2019', 10, 11, 12, 13, 15, 16],
    ],
    rowHeaders: true,
    colHeaders: true,
    contextMenu: true,
    comments: true,
    cell: [
        { row: 1, col: 1, comment: { value: 'Some comment' } },
        { row: 2, col: 2, comment: { value: 'Comment 200x50 px', style: { width: 200, height: 50 } } }
    ],
    height: 'auto',
    licenseKey: 'non-commercial-and-evaluation'
}
  1. result:
    image
@Siemienik Siemienik mentioned this issue Oct 4, 2021
68 tasks
@Siemienik Siemienik changed the title comments [RTL] Comments Oct 4, 2021
@Siemienik Siemienik added Comments Plugin RTL Right-to-left labels Oct 4, 2021
@budnix budnix self-assigned this Dec 31, 2021
@budnix budnix closed this as completed Jan 10, 2022
@Siemienik Siemienik reopened this Jan 14, 2022
@aninde
Copy link
Contributor

aninde commented Mar 14, 2022

Fixed in the v12.0.0 https://jsfiddle.net/jz6amgx3/1/

@AMBudnik
Copy link
Contributor

Closed with #8760 (RTL Support), published in Handsontable v12.

For more information please check out our Release Notes - https://handsontable.com/docs/release-notes/#_12-0-0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants