Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong typescript definition in sort function arguments of multiColumnSorting plugin #9067

Closed
ssprusakov opened this issue Dec 28, 2021 · 3 comments
Assignees
Labels
bug Regression Issues that were created while adding new changes to the source code Status: Released TypeScript

Comments

@ssprusakov
Copy link

Description

According to documentation, sort function of multiColumnSorting plugin can have object, array, or undefined types of sortConfig argument.

But when using typescript, we can pass only single column sort config.
image

Steps to reproduce

  1. Use typescript
  2. Get multiColumnSorting plugin from hot instance
  3. Try pass full sort configuration as array of objects to sort function

Demo

Not required

Your environment

  • Handsontable version: 11.0.1
  • Browser Name and version: Chrome 96.0.4664.110
  • Operating System: Windows 10
@AMBudnik
Copy link
Contributor

AMBudnik commented Dec 31, 2021

Thank you for sharing the report @ssprusakov

I will update you as soon as we fix it.

@budnix budnix self-assigned this Dec 31, 2021
@budnix budnix added the Regression Issues that were created while adding new changes to the source code label Dec 31, 2021
@aninde
Copy link
Contributor

aninde commented Jan 12, 2022

This issue is fixed for the upcoming v11.1.0.

@AMBudnik
Copy link
Contributor

Hi @ssprusakov

I have good news. Yesterday we release Handsontable v11.1.0 where this issue is solved.

Here https://handsontable.com/docs/release-notes/ is a full list of changes within that version.

Please let me know if that works for you as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Regression Issues that were created while adding new changes to the source code Status: Released TypeScript
Projects
None yet
Development

No branches or pull requests

4 participants