Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clear_column in context menu send ContextMenu.clearColumn as src #9566

Closed
ichalyshev opened this issue Jun 6, 2022 · 2 comments
Closed

clear_column in context menu send ContextMenu.clearColumn as src #9566

ichalyshev opened this issue Jun 6, 2022 · 2 comments

Comments

@ichalyshev
Copy link

I am using typescript, and I have clear_column in context menu. If I select whole column and run "Clear column" in my afterChange handler i receive src='ContextMenu.clearColumn' not 'ContextMenu.clearColumn**s**' There is no 'ContextMenu.clearColumn' in ChangeSource type.

export type ChangeSource = 'auto' | 'edit' | 'loadData' | 'populateFromArray' | 'spliceCol' |
'spliceRow' | 'timeValidate' | 'dateValidate' | 'validateCells' |
'Autofill.fill' | 'ContextMenu.clearColumns' | 'ContextMenu.columnLeft' |
'ContextMenu.columnRight' | 'ContextMenu.removeColumn' |
'ContextMenu.removeRow' | 'ContextMenu.rowAbove' | 'ContextMenu.rowBelow' |
'CopyPaste.paste' | 'UndoRedo.redo' | 'UndoRedo.undo' | 'ColumnSummary.set' |
'ColumnSummary.reset';

"typescript": "3.8"
"@handsontable/react": "^12.0.1",
"handsontable": "^12.0.1",

@AMBudnik
Copy link
Contributor

AMBudnik commented Jun 6, 2022

Thank you for sharing the issue report @ichalyshev

That is true, the ContextMenu.clearColumn string that we get as the source of change in the afterChange

Screenshot 2022-06-06 at 15 18 23

hook is not a valid string out of the ChangeSource

Screenshot 2022-06-06 at 15 18 02

Links

ChangeSource definition -

export type ChangeSource = 'auto' | 'edit' | 'loadData' | 'populateFromArray' | 'spliceCol' |

demo for tests - https://jsfiddle.net/y1k7q9hf/2/

@AMBudnik
Copy link
Contributor

Hi @ichalyshev

I just wanted to let you know that we just released Handsontable v13.1.0 where this issue is fixed.

Again, thank you for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants