Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0.0+] Cursor moves to the next row when press ENTER to confirm on Japanese IME (version 12 only) #9586

Closed
takyam-git opened this issue Jun 16, 2022 · 6 comments · Fixed by #9839
Assignees
Labels
Accessibility bug Regression Issues that were created while adding new changes to the source code Status: Released

Comments

@takyam-git
Copy link

Description

Handsontable version 11

handsontable11.mp4
  • keypress aiueo[ENTER]
  • IME word selection is confirmed
  • Cursor in B2

Handsontable version 12

handsontable12.mp4
  • keypress aiueo[ENTER]
  • IME word selection is confirmed
  • Cursor move to B3 (next row)

Steps to reproduce

  1. use Japanese IME
  2. select cell and input with IME
  3. press ENTER to confirm

Demo

import Handsontable from "handsontable";

const data = [
  ['', 'Tesla', 'Volvo', 'Toyota', 'Ford'],
  ['2019', 10, 11, 12, 13],
  ['2020', 20, 11, 14, 13],
  ['2021', 30, 15, 12, 13]
];

const container = document.getElementById('app');
const hot = new Handsontable(container, {
  data: data,
  rowHeaders: true,
  colHeaders: true
});

Your environment

  • Handsontable version: 12.0.1
  • Browser name and version: Chrome 102
  • Operating system: Mac Monterey
@adrianszymanski89
Copy link
Contributor

Hi @takyam-git

Thank you for reporting the issue. I tested it and indeed this functionality isn't working correctly. We introduced a new shortcut manager in v. 12.0.0 and that might be the reason. I will label that issue as a regression.

@adrianszymanski89 adrianszymanski89 added Accessibility Regression Issues that were created while adding new changes to the source code labels Jun 17, 2022
@adrianszymanski89 adrianszymanski89 changed the title Cursor moves to the next row when press ENTER to confirm on Japanese IME (version 12 only) [12.0.0+] Cursor moves to the next row when press ENTER to confirm on Japanese IME (version 12 only) Jun 17, 2022
@adrianszymanski89
Copy link
Contributor

Inform ZD 29519.

@krzysztofspilka krzysztofspilka added this to the 12.2 (September 2022) milestone Aug 18, 2022
@adrianszymanski89
Copy link
Contributor

Inform ZD 29816.

@budnix budnix self-assigned this Aug 25, 2022
@budnix budnix mentioned this issue Aug 25, 2022
4 tasks
@budnix budnix reopened this Sep 1, 2022
@adrianszymanski89
Copy link
Contributor

Inform Forum

@aninde
Copy link
Contributor

aninde commented Sep 20, 2022

This issue will be fixed by the upcoming v12.1.3 https://jsfiddle.net/k7qLwdat/ 
On the recording, after confirming with Enter, the selection does not move down.

Screen.Recording.2022-09-20.at.13.36.23.mov

@AMBudnik
Copy link
Contributor

Hi @takyam-git

I'm more than happy to notify you that we just released Handsontable v12.1.3 where this issue is fixed.

I'm closing this issue as solved. However, please feel free to leave a comment if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility bug Regression Issues that were created while adding new changes to the source code Status: Released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants