Support additional numeric literals: octal, binary, hexadecimal and numeric separators

[wojciechczerniak]

Description

Since #122 we support literal JS numeric formats but limited to integers and floats.

There are more numeric literals in JS: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Lexical_grammar#Numeric_literals

They should be handled by #176 as an unsupported input ATM so this can be treated as a feature request for the future.

Links

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Lexical_grammar#Numeric_literals

[izulin]

is this issue about:

parsing extra formats, so we could write

HyperFormula.buildFromArray([
      ['0xFFF', '0b10101'],
    ]);

or

supporting extra formats as a raw type:

HyperFormula.buildFromArray([
      [0xFFF, 0b10101],
    ]);

?

[wojciechczerniak]

The second one:

HyperFormula.buildFromArray([
      [0xFFF, 0b10101],
    ]);

This is just a text:

HyperFormula.buildFromArray([
      ['0xFFF', '0b10101'],
    ]);

[izulin]

then it is already automatically supported (its on the JS side, not ours)

[wojciechczerniak]

Awesome!

Can we add a test then? Binary, Octal, Hex, BigInt and Numeric Separator.

[izulin]

do we want BigInt support? this is potentially a large rework (coercions, math functions, etc)?

[wojciechczerniak]

No. We don't want it to throw an error either

[izulin]

what do you mean? what is the desired behaviour then?

[wojciechczerniak]

A message that it is not supported #195

[izulin]

Like a console.log() warning?

should we also try to cast it to float?

[wojciechczerniak]

Like a console.log() warning?

I was thinking about throwing the Unable to parse value: [] we already have. Maybe we should add type to those messages, though? BigInt may look like an Int and therefore might be confusing to the developer.

should we also try to cast it to float?

IMO No. No magic. Either we support it or not.

[izulin]

Like a console.log() warning?

I was thinking about throwing the Unable to parse value: [] we already have. Maybe we should add type to those messages, though? BigInt may look like an Int and therefore might be confusing to the developer.

should we also try to cast it to float?

IMO No. No magic. Either we support it or not.

Since we merged other PR, we now have toolset for such error messages. Added.

[wojciechczerniak]

Done in #204 and #208

[wojciechczerniak]

@izulin Since BigInt was added in TypeScript 3.2 we need to bump the dependencies because it will not build the HF with lower version

hyperformula/package.json

Line 67 in fd55f4a

"typescript": "^3.0.3",

[wojciechczerniak]

Typescript requirements bumped in #211 Thx